-
Notifications
You must be signed in to change notification settings - Fork 121
Update README.md #910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Update README.md #910
Conversation
|
👋 @Maayan-s |
📝 WalkthroughWalkthroughA single documentation update replaces the Downloads badge image URL in README.md with an elementary-data badge and changes the tracking period from total to month. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Pre-merge checks❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI Agents
In @README.md:
- Line 8: The img tag has malformed HTML: the src attribute is prematurely
closed leaving &left_text=Downloads outside the quotes; fix the <img> element by
moving the &left_text=Downloads query parameter inside the src attribute value
and ensure the src value is wrapped in quotes and the tag is properly closed
(refer to the img element and its src attribute and the left_text parameter).
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
README.md
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-09-15T06:06:05.601Z
Learnt from: arbiv
Repo: elementary-data/dbt-data-reliability PR: 861
File: macros/edr/tests/test_utils/clean_elementary_test_tables.sql:45-50
Timestamp: 2025-09-15T06:06:05.601Z
Learning: In the Elementary dbt-data-reliability codebase, the team prefers simpler, direct approaches over creating helper macros for centralized quoting logic, even when it might provide better maintainability across multiple use cases. They value code simplicity and readability over abstraction.
Applied to files:
README.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (14)
- GitHub Check: test (latest_official, bigquery) / test
- GitHub Check: test (fusion, databricks_catalog) / test
- GitHub Check: test (latest_official, databricks_catalog) / test
- GitHub Check: test (latest_official, athena) / test
- GitHub Check: test (fusion, snowflake) / test
- GitHub Check: test (latest_official, clickhouse) / test
- GitHub Check: test (fusion, bigquery) / test
- GitHub Check: test (latest_official, redshift) / test
- GitHub Check: test (latest_pre, postgres) / test
- GitHub Check: test (latest_official, postgres) / test
- GitHub Check: test (fusion, redshift) / test
- GitHub Check: test (latest_official, snowflake) / test
- GitHub Check: test (latest_official, dremio) / test
- GitHub Check: test (latest_official, trino) / test
| <a href="https://docs.elementary-data.com/data-tests/dbt/quickstart-package"><img src="https://img.shields.io/badge/docs-quickstart-orange"/></a> | ||
| <img alt="License" src="https://img.shields.io/badge/license-Apache--2.0-ff69b4"/> | ||
| <img alt="Downloads" src="https://static.pepy.tech/personalized-badge/elementary-lineage?period=total&units=international_system&left_color=grey&right_color=orange"&left_text=Downloads/> | ||
| <img alt="Downloads" src="https://static.pepy.tech/personalized-badge/elementary-data?period=month&units=international_system&left_color=grey&right_color=orange"&left_text=Downloads/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix malformed HTML syntax in the Downloads badge.
The src attribute is incorrectly closed, with the &left_text=Downloads query parameter positioned outside the attribute quotes. This breaks the HTML syntax and prevents the badge from rendering.
Current (incorrect):
<img alt="Downloads" src="https://static.pepy.tech/personalized-badge/elementary-data?period=month&units=international_system&left_color=grey&right_color=orange"&left_text=Downloads/>Expected (correct):
<img alt="Downloads" src="https://static.pepy.tech/personalized-badge/elementary-data?period=month&units=international_system&left_color=grey&right_color=orange&left_text=Downloads" />🔎 Proposed fix
-<img alt="Downloads" src="https://static.pepy.tech/personalized-badge/elementary-data?period=month&units=international_system&left_color=grey&right_color=orange"&left_text=Downloads/>
+<img alt="Downloads" src="https://static.pepy.tech/personalized-badge/elementary-data?period=month&units=international_system&left_color=grey&right_color=orange&left_text=Downloads" />🤖 Prompt for AI Agents
In @README.md at line 8, The img tag has malformed HTML: the src attribute is
prematurely closed leaving &left_text=Downloads outside the quotes; fix the
<img> element by moving the &left_text=Downloads query parameter inside the src
attribute value and ensure the src value is wrapped in quotes and the tag is
properly closed (refer to the img element and its src attribute and the
left_text parameter).
Summary by CodeRabbit
Documentation
✏️ Tip: You can customize this high-level summary in your review settings.